On 10/24/19 6:13 AM, Ilya Leoshkevich wrote:
Hello, Is there anything blocking this from getting merged?
Please see below:
This patch series fixes the following problem: linux# make kselftest TARGETS=bpf O=/mnt/linux-build # selftests: bpf: test_libbpf.sh # ./test_libbpf.sh: line 23: ./test_libbpf_open: No such file or directory # test_libbpf: failed at file test_l4lb.o # selftests: test_libbpf [FAILED] Patch 1 appends / to $(OUTPUT) in order to make it more uniform with the rest of the tree.
It isn't clear what this fixes. In addition, this patch appends an extra "/" Excerpts from make kselftest-all with this patch applied: linux_5.4/tools/testing/selftests/bpf//test_tcpnotify_user I am not seeing any reason to take this patch.
Patch 2 fixes the problem by prepending $(OUTPUT) to all members of $(TEST_PROGS). v1->v2: - Append / to $(OUTPUT). - Use $(addprefix) instead of $(foreach).
I can't reproduce this problem - I ran make kselftest O=/tmp/linux-build This might be fixing the problem in bpf case. However, I don't think this is the right fix. I would like to see this problem reproduced on another test first. thanks, -- Shuah
