On Fri, Oct 25, 2019 at 01:50:41PM +0200, Miroslav Benes wrote:
> Commit 852c8cbf34d3 ("selftests/kselftest/runner.sh: Add 45 second
> timeout per test") introduced a timeout per test. Livepatch tests could
> run longer than 45 seconds, especially on slower machines. They do not
> hang and they detect if something goes awry with internal accounting.
>
> Better than looking for an arbitrary value, just disable the timeout for
> livepatch selftests.
>
> Signed-off-by: Miroslav Benes <mbenes@xxxxxxx>
> ---
> tools/testing/selftests/livepatch/settings | 1 +
> 1 file changed, 1 insertion(+)
> create mode 100644 tools/testing/selftests/livepatch/settings
>
> diff --git a/tools/testing/selftests/livepatch/settings b/tools/testing/selftests/livepatch/settings
> new file mode 100644
> index 000000000000..e7b9417537fb
> --- /dev/null
> +++ b/tools/testing/selftests/livepatch/settings
> @@ -0,0 +1 @@
> +timeout=0
> --
> 2.23.0
>
Yes, disabling the timeout for our tests makes sense since they already
have internal checking. Tested this in a VM and looks good to me,
thanks.
Reviewed-by: Joe Lawrence <joe.lawrence@xxxxxxxxxx>
-- Joe
