On 09/10/2019 12:18, Dave Martin wrote: > On Wed, Oct 09, 2019 at 09:26:01AM +0100, Cristian Marussi wrote: >> Add some arm64/signal specific boilerplate and utility code to help >> further testcases' development. >> >> Introduce also one simple testcase mangle_pstate_invalid_compat_toggle >> and some related helpers: it is a simple mangle testcase which messes >> with the ucontext_t from within the signal handler, trying to toggle >> PSTATE state bits to switch the system between 32bit/64bit execution >> state. Expects SIGSEGV on test PASS. >> >> Reviewed-by: Dave Martin <Dave.Martin@xxxxxxx> >> Signed-off-by: Cristian Marussi <cristian.marussi@xxxxxxx> >> --- >> v7 --> v8 >> - removed unused SSBS_SYSREG > > [...] > >> diff --git a/tools/testing/selftests/arm64/signal/.gitignore b/tools/testing/selftests/arm64/signal/.gitignore >> new file mode 100644 >> index 000000000000..e5aeae45febb >> --- /dev/null >> +++ b/tools/testing/selftests/arm64/signal/.gitignore >> @@ -0,0 +1,3 @@ >> +!*.[ch] >> +mangle_* >> +fake_sigreturn_* > > I think the !*.[ch] line needs to come last. > > Re-including *.[ch] on the first line has no effect because no files > have been excluded yet. > > (This looks like it was my mistake when I originally suggested using > wildcards here -- apologies for that!) > > I'm happy for you to keey my Reviewed-by on that change. > Moved to last in v9 Cristian > [...] > > Cheers > ---Dave >
