Hi Shuah,
On Tue, Sep 17, 2019 at 08:40:22PM +0200, Eugeniu Rosca wrote:
> From: "George G. Davis" <george_davis@xxxxxxxxxx>
>
> The newly added optional file argument does not validate if the
> file is indeed a watchdog, e.g.:
>
> ./watchdog-test -f /dev/zero
> Watchdog Ticking Away!
>
> Fix it by confirming that the WDIOC_GETSUPPORT ioctl succeeds.
>
> Fixes: c3f2490d6e9257 ("selftests: watchdog: Add optional file argument")
> Reported-by: Eugeniu Rosca <erosca@xxxxxxxxxxxxxx>
> Signed-off-by: George G. Davis <george_davis@xxxxxxxxxx>
> Signed-off-by: Eugeniu Rosca <erosca@xxxxxxxxxxxxxx>
> ---
> v3:
> - Used v1 as starting point and simplified commit description
> - Added Fixes tag (WARNING: commit id is from linux-next!)
> - No change in the contents
> - Applied cleanly to the same base as used in [v1]
Can we have your confirmation the patches look fine now?
--
Best Regards,
Eugeniu
