On Tue, Aug 13, 2019 at 10:52 PM Brendan Higgins <brendanhiggins@xxxxxxxxxx> wrote: > > ## TL;DR > > This revision addresses comments from Stephen and Bjorn Helgaas. Most > changes are pretty minor stuff that doesn't affect the API in anyway. > One significant change, however, is that I added support for freeing > kunit_resource managed resources before the test case is finished via > kunit_resource_destroy(). Additionally, Bjorn pointed out that I broke > KUnit on certain configurations (like the default one for x86, whoops). > > Based on Stephen's feedback on the previous change, I think we are > pretty close. I am not expecting any significant changes from here on > out. Stephen, it looks like you have just replied with "Reviewed-bys" on all the remaining emails that you looked at. Is there anything else that we are missing? Or is this ready for Shuah to apply? [...] Cheers!
