Re: [PATCH v3] selftests/livepatch: add test skip handling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 07/24/2019 12:45 PM, shuah wrote:
On 7/24/19 12:27 AM, Petr Mladek wrote:
On Mon 2019-07-22 10:05:44, Joe Lawrence wrote:
Add a skip() message function that stops the test, logs an explanation,
and sets the "skip" return code (4).

Before loading a livepatch self-test kernel module, first verify that
we've built and installed it by running a 'modprobe --dry-run'.  This
should catch a few environment issues, including !CONFIG_LIVEPATCH and
!CONFIG_TEST_LIVEPATCH.  In these cases, exit gracefully with the new
skip() function.

Reported-by: Jiri Benc <jbenc@xxxxxxxxxx>
Suggested-by: Shuah Khan <shuah@xxxxxxxxxx>
Signed-off-by: Joe Lawrence <joe.lawrence@xxxxxxxxxx>

Reviewed-by: Petr Mladek <pmladek@xxxxxxxx>

Best Regards,
Petr

PS: No need to send v4. The missing "to", suggested by Shuah, could
     get added when pushing the patch into the repo.


I can't make changes to the patch. I can adjust the commit log at times
and correct merge conflicts.

I would like to see v4 for this.


We should clarify for which tree this and "[PATCH] selftests/livepatch: push and pop dynamic debug config​" would be merged. I had assumed this would go to the livepatching tree, but Shuah, do you prefer that selftest-centric patches go through the selftests tree?

I'm okay with either and can send up a v4 if needed. But also this would be good to know for future changesets like this, we can perhaps mark the destination branch in advance.

Thanks,

-- Joe




[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux