On 7/22/19 11:19 AM, Kees Cook wrote:
On Thu, Jul 18, 2019 at 05:48:30PM +0200, Ilya Leoshkevich wrote:
Hello,
Is there a reason why kselftest Makefile uses plain "make" instead of
"$(MAKE)"?
Because of this, "make kselftest TARGETS=bpf -j12" ends up building all
bpf tests sequentially, since the top make's jobserver is not shared
with its children. Replacing "make" with "$(MAKE)" helps, but since
other Makefiles use "$(MAKE)", it looks as if this has been done
intentionally.
I suspect it's just an oversight. Can you send a patch to fix this?
Sorry for late reply. I have been traveling.
Please make the change and send the patch. Also make sure all the
use-cases work?
i.e make kselftest
make -c <individual tests build>
make -C <selftest build - all tests invoking selftest Makefile)
I recall there are some issues using $(MAKE) when I added the
support a while back. I don't recall what it was.
thanks,
-- Shuah
