On 7/12/19 11:58 AM, Joe Lawrence wrote:
On Fri, Jul 12, 2019 at 11:43:02AM -0600, shuah wrote:
Hi Joe,
[ ... snip ... ]
The one thing I am not seeing is Skip handling. Without that users will
complain livepatch test is failing as opposed to that the test can't
run due to unmet dependencies and skipped.
Maybe that is all you need? I would recommend going in that direction
instead of Arch check.
Okay, I see that kselftest/runner.sh compares test return code with
skip_rc=4 to determine SKIP status... so perhaps our scripts could
perform a simple "modinfo" on their test modules to determine if they
have been built and installed? If not found, just SKIP to the next
test.
Yes. That would fix the problem.
tools/testing/selftests/kselftest_module.sh has hooks to help you
with modules checks. e.g: assert_have_module
thanks,
-- Shuah
