On Thu, May 23, 2019 at 5:31 PM Alakesh Haloi <alakesh.haloi@xxxxxxxxx> wrote: > > Add missing header file following compiler warning > > prog_tests/flow_dissector.c: In function ‘tx_tap’: > prog_tests/flow_dissector.c:175:9: warning: implicit declaration of function ‘writev’; did you mean ‘write’? [-Wimplicit-function-declaration] > return writev(fd, iov, ARRAY_SIZE(iov)); > ^~~~~~ > write > > Signed-off-by: Alakesh Haloi <alakesh.haloi@xxxxxxxxx> The patch looks good. Please add a "Fixes" tag, so the fix can be back ported properly. Also, please specify which tree the patch should be applied with [PATCH bpf] or [PATCH bpf-next]. Thanks, Song > --- > tools/testing/selftests/bpf/prog_tests/flow_dissector.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tools/testing/selftests/bpf/prog_tests/flow_dissector.c b/tools/testing/selftests/bpf/prog_tests/flow_dissector.c > index fbd1d88a6095..c938283ac232 100644 > --- a/tools/testing/selftests/bpf/prog_tests/flow_dissector.c > +++ b/tools/testing/selftests/bpf/prog_tests/flow_dissector.c > @@ -3,6 +3,7 @@ > #include <error.h> > #include <linux/if.h> > #include <linux/if_tun.h> > +#include <sys/uio.h> > > #define CHECK_FLOW_KEYS(desc, got, expected) \ > CHECK_ATTR(memcmp(&got, &expected, sizeof(got)) != 0, \ > -- > 2.17.1 >
