On 17/05/2019 04.45, Peter Xu wrote: > Hi, Thomas, > > On Thu, May 16, 2019 at 03:02:57PM +0200, Thomas Huth wrote: >> So far the KVM selftests are compiled without any compiler warnings >> enabled. That's quite bad, since we miss a lot of possible bugs this >> way. Let's enable at least "-Wall" and some other useful warning flags >> now. >> >> Signed-off-by: Thomas Huth <thuth@xxxxxxxxxx> >> --- >> This patch fixes most of the warnings in the x86 code already - but >> for some warnings, I was not quite sure (e.g. about the need for the >> kvm_get_supported_cpuid_entry(1) in some tests), so I did not touch > > If you mean the two calls in state_test and evmcs_test I would agree > they should be dropped directly. Yes, that were the once I had in mind. I'll drop them in v2. > Just to mention that the patch may not apply cleanly to kvm/queue now > probably because the dirty-log-test.c touchup recently, so may need a > rebase. Otherwise it looks nice at least to me to have these checks. Ok, thanks for the hint, I'll rebase and send a v2. Thomas
