Re: [PATCH] selftests/bpf: Fix compile warning in bpf selftest

[Alexei Starovoitov <alexei.starovoitov@xxxxxxxxx>]

On Tue, May 7, 2019 at 4:12 PM Alakesh Haloi <alakesh.haloi@xxxxxxxxx> wrote:
>
> This fixes the following compile time warning
>
> flow_dissector_load.c: In function ‘detach_program’:
> flow_dissector_load.c:55:19: warning: format not a string literal and no format arguments [-Wformat-security]
>    error(1, errno, command);
>                    ^~~~~~~
> Signed-off-by: Alakesh Haloi <alakesh.haloi@xxxxxxxxx>
> ---
>  tools/testing/selftests/bpf/flow_dissector_load.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/bpf/flow_dissector_load.c b/tools/testing/selftests/bpf/flow_dissector_load.c
> index 77cafa66d048..7136ab9ffa73 100644
> --- a/tools/testing/selftests/bpf/flow_dissector_load.c
> +++ b/tools/testing/selftests/bpf/flow_dissector_load.c
> @@ -52,7 +52,7 @@ static void detach_program(void)
>         sprintf(command, "rm -r %s", cfg_pin_path);
>         ret = system(command);
>         if (ret)
> -               error(1, errno, command);
> +               error(1, errno, "%s", command);
>  }

it was fixed month ago.