Kevin 'ldir' Darbyshire-Bryant <ldir@xxxxxxxxxxxxxxxxxxxxxxx> writes: >> On 5 May 2019, at 11:23, Greg KH <greg@xxxxxxxxx> wrote: >> >> On Sun, May 05, 2019 at 10:15:43AM +0000, Kevin 'ldir' Darbyshire-Bryant wrote: >>> --- /dev/null >>> +++ b/net/sched/act_ctinfo.c >>> @@ -0,0 +1,407 @@ >>> +// SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note >> > > Hey Greg, thanks for the review. > >> How can a .c file, buried in the kernel tree, have a Linux-syscall-note >> exception to it? > > Because I’m a moron and nobody else spotted it. >> >> Are you _sure_ that is ok? That license should only be for files in the >> uapi header directory. > > Expect a v3 shortly. I shall wear your chastisement with honour :-) While you're at it, you don't actually need the GPL text blob when using the SPDX headers... :) -Toke
