Re: [RFC][PATCH v3] ftrace/x86_64: Emulate call function while updating in breakpoint handler

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Steven Rostedt <rostedt@xxxxxxxxxxx>
Subject: Re: [RFC][PATCH v3] ftrace/x86_64: Emulate call function while updating in breakpoint handler
From: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
Date: Wed, 1 May 2019 11:59:05 -0700
Cc: Andy Lutomirski <luto@xxxxxxxxxx>, Peter Zijlstra <peterz@xxxxxxxxxxxxx>, Nicolai Stange <nstange@xxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, Borislav Petkov <bp@xxxxxxxxx>, "H. Peter Anvin" <hpa@xxxxxxxxx>, "the arch/x86 maintainers" <x86@xxxxxxxxxx>, Josh Poimboeuf <jpoimboe@xxxxxxxxxx>, Jiri Kosina <jikos@xxxxxxxxxx>, Miroslav Benes <mbenes@xxxxxxx>, Petr Mladek <pmladek@xxxxxxxx>, Joe Lawrence <joe.lawrence@xxxxxxxxxx>, Shuah Khan <shuah@xxxxxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>, Tim Chen <tim.c.chen@xxxxxxxxxxxxxxx>, Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>, Mimi Zohar <zohar@xxxxxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Nick Desaulniers <ndesaulniers@xxxxxxxxxx>, Nayna Jain <nayna@xxxxxxxxxxxxx>, Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>, Joerg Roedel <jroedel@xxxxxxx>, Linux List Kernel Mailing <linux-kernel@xxxxxxxxxxxxxxx>, live-patching@xxxxxxxxxxxxxxx, "open list:KERNEL SELFTEST FRAMEWORK" <linux-kselftest@xxxxxxxxxxxxxxx>
In-reply-to: <20190501145200.6c095d7f@oasis.local.home>

On Wed, May 1, 2019 at 11:52 AM Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
>
> I got Peter's patch working. Here it is. What do you think?

I can tell from just looking at it for five seconds that at least the
32-bit case is buggy.

You can't look at CS(%rsp) without first also checking that you're not
coming from vm86 mode.

But other than that I guess it does end up being pretty simple.

             Linus

Follow-Ups:
- Re: [RFC][PATCH v3] ftrace/x86_64: Emulate call function while updating in breakpoint handler
  - From: Peter Zijlstra

References:
- [RFC][PATCH v3] ftrace/x86_64: Emulate call function while updating in breakpoint handler
  - From: Steven Rostedt
- Re: [RFC][PATCH v3] ftrace/x86_64: Emulate call function while updating in breakpoint handler
  - From: Linus Torvalds
- Re: [RFC][PATCH v3] ftrace/x86_64: Emulate call function while updating in breakpoint handler
  - From: Steven Rostedt

Prev by Date: Re: [RFC][PATCH] ftrace/x86: Emulate call function while updating in breakpoint handler
Next by Date: Re: [RFC][PATCH] ftrace/x86: Emulate call function while updating in breakpoint handler
Previous by thread: Re: [RFC][PATCH v3] ftrace/x86_64: Emulate call function while updating in breakpoint handler
Next by thread: Re: [RFC][PATCH v3] ftrace/x86_64: Emulate call function while updating in breakpoint handler
Index(es):
- Date
- Thread

[Index of Archives] [Linux Wireless] [Linux Kernel] [ATH6KL] [Linux Bluetooth] [Linux Netdev] [Kernel Newbies] [Share Photos] [IDE] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux ATA RAID] [Samba] [Device Mapper]