On Mon, Apr 29, 2019 at 8:29 AM Mathieu Desnoyers <mathieu.desnoyers@xxxxxxxxxxxx> wrote: > > Ongoing work for asm goto support from clang requires the > -no-integrated-as compiler flag. > > This compiler flag is present in the toplevel kernel Makefile, > but is not replicated for selftests. Add it specifically for > the rseq selftest which requires asm goto. > > Link: https://reviews.llvm.org/D56571 > Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@xxxxxxxxxxxx> > CC: Nick Desaulniers <ndesaulniers@xxxxxxxxxx> > CC: Thomas Gleixner <tglx@xxxxxxxxxxxxx> > CC: Joel Fernandes <joelaf@xxxxxxxxxx> > CC: Peter Zijlstra <peterz@xxxxxxxxxxxxx> > CC: Catalin Marinas <catalin.marinas@xxxxxxx> > CC: Dave Watson <davejwatson@xxxxxx> > CC: Will Deacon <will.deacon@xxxxxxx> > CC: Shuah Khan <shuah@xxxxxxxxxx> > CC: Andi Kleen <andi@xxxxxxxxxxxxxx> > CC: linux-kselftest@xxxxxxxxxxxxxxx > CC: "H . Peter Anvin" <hpa@xxxxxxxxx> > CC: Chris Lameter <cl@xxxxxxxxx> > CC: Russell King <linux@xxxxxxxxxxxxxxxx> > CC: Michael Kerrisk <mtk.manpages@xxxxxxxxx> > CC: "Paul E . McKenney" <paulmck@xxxxxxxxxxxxxxxxxx> > CC: Paul Turner <pjt@xxxxxxxxxx> > CC: Boqun Feng <boqun.feng@xxxxxxxxx> > CC: Josh Triplett <josh@xxxxxxxxxxxxxxxx> > CC: Steven Rostedt <rostedt@xxxxxxxxxxx> > CC: Ben Maurer <bmaurer@xxxxxx> > CC: linux-api@xxxxxxxxxxxxxxx > CC: Andy Lutomirski <luto@xxxxxxxxxxxxxx> > CC: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> > CC: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> > --- > tools/testing/selftests/rseq/Makefile | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/rseq/Makefile b/tools/testing/selftests/rseq/Makefile > index c30c52e1d0d2..d6469535630a 100644 > --- a/tools/testing/selftests/rseq/Makefile > +++ b/tools/testing/selftests/rseq/Makefile > @@ -1,5 +1,11 @@ > # SPDX-License-Identifier: GPL-2.0+ OR MIT > -CFLAGS += -O2 -Wall -g -I./ -I../../../../usr/include/ -L./ -Wl,-rpath=./ > + > +ifneq ($(shell $(CC) --version 2>&1 | head -n 1 | grep clang),) > +CLANG_FLAGS += -no-integrated-as > +endif > + > +CFLAGS += -O2 -Wall -g -I./ -I../../../../usr/include/ -L./ -Wl,-rpath=./ \ > + $(CLANG_FLAGS) The top level Makefile exports $(CLANG_FLAGS), which should contain `-no-integrated-as`. Is that available here? If so, then you can just add `$(CLANG_FLAGS)`, no compiler check needed. If not, maybe the test for CONFIG_CC_IS_CLANG is cleaner? Thanks for the patch, and helping test asm goto in Clang! -- Thanks, ~Nick Desaulniers
