On Wed, Apr 24, 2019 at 11:58 AM Masayoshi Mizuma <msys.mizuma@xxxxxxxxx> wrote: > > Hi Brendan, > > KUNIT_ASSERT_NOT_ERR_OR_NULL() should be replaced to > KUNIT_EXPECT_NOT_ERR_OR_NULL(), right? Generally speaking, no. There may be places that I have used it improperly, but I think it is generally okay to use. If you are refering to the discussion with Frank and Stephen in RFC v4, my take was that the resolution was that there were some things I needed to fix in its implementation, but it is conceptually okay, and that Frank doesn't want me to use it in drivers/of/unittest.c. Consequently, I fixed the implementation issues that Frank and Stephen pointed out, and I am holding off on drivers/of/unittest.c for this patchset. The usage in this file should be fine. > > On Thu, Apr 04, 2019 at 03:06:49PM -0700, Brendan Higgins wrote: > > Add documentation for KUnit, the Linux kernel unit testing framework. > > - Add intro and usage guide for KUnit > > - Add API reference > > > > Signed-off-by: Felix Guo <felixguoxiuping@xxxxxxxxx> > > Signed-off-by: Brendan Higgins <brendanhiggins@xxxxxxxxxx> > > --- > > <snip> <snip> Cheers
