On Tue, Apr 16, 2019 at 4:21 PM shuah <shuah@xxxxxxxxxx> wrote:
>
> On 4/16/19 5:16 PM, Kees Cook wrote:
> > On Tue, Apr 16, 2019 at 6:11 PM shuah <shuah@xxxxxxxxxx> wrote:
> >>
> >> Hi Kees,
> >>
> >> Thanks for the patch.
> >>
> >> On 4/9/19 5:55 PM, Kees Cook wrote:
> >>> In order to improve the reusability of the kselftest test running logic,
> >>> this extracts the single-test logic from lib.mk into kselftest/runner.sh
> >>> which lib.mk can call directly. No changes in output.
> >>>
> >>> As part of the change, this removes the unused "summary" Makefile variable
> >>> (and tests). However, future merging with the "emit_tests" target needs
> >>> to be able to redirect output, so a new "logfile" variable is introduced.
> >>
> >> Shouldn't the selftests/Makefile need update for "summary" removal??
> >>
> >
> > I didn't see anything using "summary" except as a --summary argument
> > to the run_kselftests.sh script. Maybe I missed it?
> >
>
> It is in the selftests/Makefile install target.
Right: it's used only by the run_kselftest.sh script:
ALL_SCRIPT := $(INSTALL_PATH)/run_kselftest.sh
install:
...
echo "if [ \"\$$1\" = \"--summary\" ]; then" >> $(ALL_SCRIPT)
So, I think this entire series can land. Is there other feedback I
should incorporate? I'd like to see it get some -next testing...
Thanks!
--
Kees Cook
