Re: [PATCH] selftests/lib.mk: Move test output to diagnostic lines

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Apr 8, 2019 at 2:32 PM shuah <shuah@xxxxxxxxxx> wrote:
> Couple of things to consider:
> - will this work on embedded test system with limited applications shell
>    support?

I was assuming the availability of "stdbuf" which is part of
coreutils, and "perl" which is already required for at least one other
test (sysctl). What do you have in mind for the "maximum supported
environment" (and where's best to document this)? Also, I see python
is used by several tests. Should python be considered instead of perl?

> - It does add dependecy on perl for running tests - not a problem since
>    kernel build system uses it, however it might not be the case when
>    tests get run on system without perl.

I could likely rewrite the "prefix.pl" in C, and the test could use a
built binary instead? Or in python (as noted above). Where are tests
being run right now with such a limited environment?

> - there is the emit_tests support that creates a shell script that runs.
>    The results format should stay the is same when tests get run using
>    run_tests vs. tests are built and installed. Take a look at emit_tests
>    and EMIT_TESTS in Makefile and lib.mk

Ah yeah. I will adjust EMIT_TESTS too.

Thanks!

-- 
Kees Cook



[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux