Re: [PATCH kselftest-next] selftests: cgroup: fix cleanup path in test_memcg_subtree_control()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Apr 08, 2019 at 12:53:39PM -0600, shuah wrote:
> On 3/27/19 8:56 PM, Roman Gushchin wrote:
> > Dan reported, that cleanup path in test_memcg_subtree_control()
> > triggers a static checker warning:
> >    ./tools/testing/selftests/cgroup/test_memcontrol.c:76 \
> >    test_memcg_subtree_control()
> >    error: uninitialized symbol 'child2'.
> > 
> > Fix this by initializing child2 and parent2 variables and
> > split the cleanup path into few stages.
> > 
> > Signed-off-by: Roman Gushchin <guro@xxxxxx>
> > Fixes: 84092dbcf901 ("selftests: cgroup: add memory controller self-tests")
> > Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> > Cc: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> > Cc: Shuah Khan (Samsung OSG) <shuah@xxxxxxxxxx>
> > Cc: Mike Rapoport <rppt@xxxxxxxxxxxxxxxxxx>
> 
> 
> From and Signed-off don't match. Please fix it and resend the patch.

Done.

Thank you!

Roman




[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux