Re: [PATCH] bpf, tests: tweak endianness selection

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On (03/19/19 09:01), Stanislav Fomichev wrote:
> > diff --git a/tools/testing/selftests/bpf/bpf_endian.h b/tools/testing/selftests/bpf/bpf_endian.h
> > index b25595ea4a78..ba06222963d5 100644
> > --- a/tools/testing/selftests/bpf/bpf_endian.h
> > +++ b/tools/testing/selftests/bpf/bpf_endian.h
> > @@ -20,38 +20,17 @@
> >   * use different targets.
> >   */
> >  #if __BYTE_ORDER__ == __ORDER_LITTLE_ENDIAN__
> > -# define __bpf_ntohs(x)			__builtin_bswap16(x)
> > -# define __bpf_htons(x)			__builtin_bswap16(x)
> > -# define __bpf_constant_ntohs(x)	___constant_swab16(x)
> > -# define __bpf_constant_htons(x)	___constant_swab16(x)
> This breaks the build until your next patch is applied (in other
> words, breaks bisection). Can we do it in three steps?

Bummer!
I thought about applying the second patch (flow_dissector.c) first
and then the first one (bpf/bpf_endian.h).

> Convert to swab (without breaking existing tests), convert the tests,
> remove unused __bpf_xyz defines?

OK.

> Could you also send it as a series (git format-patch --thread)? Those
> patches depend on each other. And pls use [PATCH bpf-next] ... subj.

Right. I figured out that I also need to patch flow_dissector.c after
I sent out bpf/bpf_endian.h patch.

Sorry about that, will fix.

	-ss



[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux