On Tue, Mar 5, 2019 at 1:27 AM Mathieu Desnoyers <mathieu.desnoyers@xxxxxxxxxxxx> wrote: > > ----- On Mar 4, 2019, at 1:53 PM, Souptick Joarder jrdr.linux@xxxxxxxxx wrote: > > > On Tue, Mar 5, 2019 at 12:20 AM Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote: > >> > >> On Tue, Mar 05, 2019 at 12:08:27AM +0530, Souptick Joarder wrote: > >> > Remove duplicate header which is included twice > >> > > >> > Signed-off-by: Sabyasachi Gupta <sabyasachi.linux@xxxxxxxxx> > >> > Signed-off-by: Souptick Joarder <jrdr.linux@xxxxxxxxx> > >> > >> That SoB chain is invalid. > > > > I didn't get why it is invalid ? > > I think it's about having the author of the patch (From) as first > Signed-off-by, and then apply following Signed-off-by by maintainers > who pick up the patch. (That's what I am used to see) > > What is the intent behind the second Signed-off-by by Sabyasachi Gupta ? Sabyasachi is the author and I am posting his patches as his email client has some issue. I think I need to add Sabyasachi's From: @ the beginning of change log. Andrew suggested the same in another thread. > > Thanks, > > Mathieu > > -- > Mathieu Desnoyers > EfficiOS Inc. > http://www.efficios.com