Re: [PATCH] selftests/networking: remove timestamping clean target

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 8 Jan 2019 at 10:25, Anders Roxell <anders.roxell@xxxxxxxxxx> wrote:
>
> Commit cda261f421ba ("selftests: add txtimestamp kselftest") introduced
> a warning:
>
> Makefile:14: warning: overriding recipe for target 'clean'
> ../../lib.mk:137: warning: ignoring old recipe for target 'clean'
>
> Theres no need for timestamping to have its own 'clean' target. The
> lib.mk file's 'clean' target gets included to the timestamping Makefile
> and that should be enough.
>
> Fixes: cda261f421ba ("selftests: add txtimestamp kselftest")
> Signed-off-by: Anders Roxell <anders.roxell@xxxxxxxxxx>
> ---
>  tools/testing/selftests/networking/timestamping/Makefile | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/tools/testing/selftests/networking/timestamping/Makefile b/tools/testing/selftests/networking/timestamping/Makefile
> index 9050eeea5f5f..1de8bd8ccf5d 100644
> --- a/tools/testing/selftests/networking/timestamping/Makefile
> +++ b/tools/testing/selftests/networking/timestamping/Makefile
> @@ -9,6 +9,3 @@ all: $(TEST_PROGS)
>  top_srcdir = ../../../../..
>  KSFT_KHDR_INSTALL := 1
>  include ../../lib.mk
> -
> -clean:
> -       rm -fr $(TEST_GEN_FILES)
> --
> 2.20.1
>

Does this make sense?

Cheers,
Anders



[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux