On Wed, Jan 23, 2019 at 07:15:01AM -0700, shuah wrote: > On 1/23/19 4:00 AM, Greg KH wrote: > > On Wed, Jan 23, 2019 at 11:54:58AM +0100, Christian Brauner wrote: > > > On Thu, Jan 17, 2019 at 12:48:54PM +0100, Christian Brauner wrote: > > > > This adds the promised selftest for binderfs. It will verify the following > > > > things: > > > > - binderfs mounting works > > > > - binder device allocation works > > > > - performing a binder ioctl() request through a binderfs device works > > > > - binder device removal works > > > > - binder-control removal fails > > > > - binderfs unmounting works > > > > > > > > The tests are performed both privileged and unprivileged. The latter > > > > verifies that binderfs behaves correctly in user namespaces. > > > > > > > > Cc: Todd Kjos <tkjos@xxxxxxxxxx> > > > > Signed-off-by: Christian Brauner <christian.brauner@xxxxxxxxxx> > > > > > > Hey Shuah, > > > > > > If you're ok with the patch in its current form, can you please make > > > sure that this still lands in 5.0? If at all possible I'd like to have > > > all ducks in a row and release binderfs with selftests and everything. > > > :) > > > > The patch is good and I was planning to get this into 5.1. > > > I can take it in my tree with the other binderfs patches if I can get an > > ack from Shuah. > > > > Great. It is good for the test patch to go with the other binderfs > patches. > > Acked-by: Shuah Khan <shuah@xxxxxxxxxx> Thanks for the quick response! Christian