On Wed, Nov 28, 2018 at 1:16 PM Rob Herring <robh@xxxxxxxxxx> wrote: > > On Wed, Nov 28, 2018 at 1:38 PM Brendan Higgins > <brendanhiggins@xxxxxxxxxx> wrote: > > diff --git a/arch/um/kernel/um_arch.c b/arch/um/kernel/um_arch.c > > index a818ccef30ca2..bd58ae3bf4148 100644 > > --- a/arch/um/kernel/um_arch.c > > +++ b/arch/um/kernel/um_arch.c > > +#if IS_ENABLED(CONFIG_OF_UNITTEST) > > + unflatten_device_tree(); > > +#endif > > Kind of strange to have this in the arch code. I'd rather have this in > the unittest code if possible. Can we have an initcall conditional on > CONFIG_UM in the unittest do this? Side note, use a C if with > IS_ENABLED() whenever possible instead of pre-processor #if. Yeah, that makes more sense. I will send a separate patch. > > I'll take a fix separately as it was on my todo to fix. I've got the > unit tests running in a gitlab CI job now[1]. > > Rob > > [1] https://gitlab.com/robherring/linux-dt-unittest/pipelines
