On Thu, Nov 29, 2018 at 7:40 PM Luis Chamberlain <mcgrof@xxxxxxxxxx> wrote: > > On Wed, Nov 28, 2018 at 11:36:24AM -0800, Brendan Higgins wrote: > > Add a test for string stream along with a simpler example. > > > > Signed-off-by: Brendan Higgins <brendanhiggins@xxxxxxxxxx> > > --- > > kunit/Kconfig | 12 ++++++ > > kunit/Makefile | 4 ++ > > kunit/example-test.c | 88 ++++++++++++++++++++++++++++++++++++++ > > BTW if you need another more concrete but very simple example I think it > may be possible to port tools/testing/selftests/sysctl/sysctl.sh + > lib/test_sysctl.c into a kunit test. Correct me if I'm wrong. I think that is pretty doable. I don't know that I want to shoot for that on the next revision. But I can definitely do it in a later revision, or a later patchset, unless you would strongly prefer it now, that is. > > I think that would show the differences clearly between selftests and > kunit as well. True. Maybe a good thing to shoot for once the DT tests are in order?
