Re: [PATCH] selftest/bpf : file resource leak

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Oct 17, 2018 at 09:41:25AM -0400, Peng Hao wrote:
> 
> From: Peng Hao <peng.hao2@xxxxxxxxxx>
> 
> FILE pointer variable f is opened but never closed.
> 
> Signed-off-by: Peng Hao <peng.hao2@xxxxxxxxxx>
> ---
>  tools/testing/selftests/bpf/trace_helpers.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tools/testing/selftests/bpf/trace_helpers.c b/tools/testing/selftests/bpf/trace_helpers.c
> index cabe2a3..a3d1dac 100644
> --- a/tools/testing/selftests/bpf/trace_helpers.c
> +++ b/tools/testing/selftests/bpf/trace_helpers.c
> @@ -41,6 +41,7 @@ int load_kallsyms(void)
>  		syms[i].name = strdup(func);
>  		i++;
>  	}
> +	fclose(f);

looks good.
please resubmit cc-ing netdev, so it gets into patchwork and we can apply it properly.
Please change subj to [PATCH bpf-next] and add a Fixes tag.
Thanks!




[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux