On 14 May 2018 at 21:20, Daniel Borkmann <daniel@xxxxxxxxxxxxx> wrote: > On 05/14/2018 01:58 PM, Anders Roxell wrote: >> If the kernel headers aren't installed we can't build all the tests. >> Add a new make target rule 'khdr' in the file lib.mk to generate the >> kernel headers and that gets include for every test-dir Makefile that >> includes lib.mk If the testdir in turn have its own sub-dirs the >> top_srcdir needs to be set to the linux-rootdir to be able to generate >> the kernel headers. >> >> Signed-off-by: Anders Roxell <anders.roxell@xxxxxxxxxx> >> Reviewed-by: Fathi Boudra <fathi.boudra@xxxxxxxxxx> >> --- >> Makefile | 14 +------------- >> scripts/subarch.include | 13 +++++++++++++ >> tools/testing/selftests/android/Makefile | 2 +- >> tools/testing/selftests/android/ion/Makefile | 1 + >> tools/testing/selftests/bpf/Makefile | 5 ++--- >> tools/testing/selftests/futex/functional/Makefile | 1 + >> tools/testing/selftests/gpio/Makefile | 7 ++----- >> tools/testing/selftests/kvm/Makefile | 7 ++----- >> tools/testing/selftests/lib.mk | 10 ++++++++++ >> tools/testing/selftests/vm/Makefile | 4 ---- >> 10 files changed, 33 insertions(+), 31 deletions(-) >> create mode 100644 scripts/subarch.include > [...] >> diff --git a/tools/testing/selftests/bpf/Makefile b/tools/testing/selftests/bpf/Makefile >> index 438d4f93875b..9741609a0eb1 100644 >> --- a/tools/testing/selftests/bpf/Makefile >> +++ b/tools/testing/selftests/bpf/Makefile >> @@ -16,9 +16,8 @@ LDLIBS += -lcap -lelf -lrt -lpthread >> TEST_CUSTOM_PROGS = $(OUTPUT)/urandom_read >> all: $(TEST_CUSTOM_PROGS) >> >> -$(TEST_CUSTOM_PROGS): urandom_read >> - >> -urandom_read: urandom_read.c >> +$(TEST_CUSTOM_PROGS):| khdr >> +$(TEST_CUSTOM_PROGS): urandom_read.c >> $(CC) -o $(TEST_CUSTOM_PROGS) -static $< >> >> # Order correspond to 'make run_tests' order > > Can you elaborate on the error in BPF you're seeing that would force a > headers_install for it? BPF shouldn't be affected, a new revision of the patch does not touch the bpf/Makefile. I will send out a patch soon. Cheers, Anders > Some people are running the tools/ infrastructure > (incl. BPF kselftests) outside of kernel tree where this dependency would > break their setup. Why BPF bits cannot be fixed otherwise? > > Thanks, > Daniel -- To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
