On 05/07/2018 12:45 PM, Shuah Khan wrote: > On 05/04/2018 07:52 PM, Mike Kravetz wrote: >> On 05/04/2018 06:13 PM, Shuah Khan (Samsung OSG) wrote: >>> When memfd test is skipped because of unmet dependencies and/or unsupported >>> configuration, it returns non-zero value which is treated as a fail by the >>> Kselftest framework. This leads to false negative result even when the test >>> could not be run. >>> >>> Change it to return kselftest skip code when a test gets skipped to >>> clearly report that the test could not be run. >>> >>> Added an explicit check for root user and return skip code. >>> >>> Kselftest framework SKIP code is 4 and the framework prints appropriate >>> messages to indicate that the test is skipped. >>> >>> Signed-off-by: Shuah Khan (Samsung OSG) <shuah@xxxxxxxxxx> >>> --- >>> tools/testing/selftests/memfd/run_tests.sh | 10 +++++++++- >>> 1 file changed, 9 insertions(+), 1 deletion(-) >>> >>> diff --git a/tools/testing/selftests/memfd/run_tests.sh b/tools/testing/selftests/memfd/run_tests.sh >>> index c2d41ed81b24..88dc206a69b7 100755 >>> --- a/tools/testing/selftests/memfd/run_tests.sh >>> +++ b/tools/testing/selftests/memfd/run_tests.sh >>> @@ -1,6 +1,14 @@ >>> #!/bin/bash >>> # please run as root >>> >>> +# Kselftest framework requirement - SKIP code is 4. >>> +ksft_skip=4 >>> + >>> +if [ $UID != 0 ]; then >>> + echo "Please run this test as root" >>> + exit $ksft_skip >>> +fi >>> + Moving root check this far up messes the test up and requires root access for run_fuse_test.sh and memfd_test which is incorrect. I will re-do the patch thanks, -- Shuah -- To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
