On Tue, Mar 27, 2018 at 03:19:26PM -0600, Shuah Khan wrote: > On 03/26/2018 09:11 PM, changbin.du@xxxxxxxxx wrote: > > From: Changbin Du <changbin.du@xxxxxxxxx> > > > > The tools/build/Makefile.build use 'OUTPUT' variable as below example: > > objprefix := $(subst ./,,$(OUTPUT)$(dir)/) > > > > So it requires the 'OUTPUT' already has a slash at the end. > > > > This patch can kill below odd paths: > > make[3]: Entering directory '/home/changbin/work/linux/tools/gpio' > > CC /home/changbin/work/linux/tools/testing/selftests/gpiolsgpio.o > > CC /home/changbin/work/linux/tools/testing/selftests/gpiogpio-utils.o > > LD /home/changbin/work/linux/tools/testing/selftests/gpiolsgpio-in.o > > > > A correct path should be: > > /home/changbin/work/linux/tools/testing/selftests/gpio/lsgpio.o > > > > Signed-off-by: Changbin Du <changbin.du@xxxxxxxxx> > > Are you seeing this when you run "make kselftest" - if gpio is the > only test compile that fails, it should be fixed in gpio/Makefile, > not is the common Makefile. > I only saw error in gpio, but I also saw some kselftest Makefiles having string concatenation as '$(OUTPUT)$(dir)'. So the rule is not aligned all over. They just didn't produce any errors so far. By the way, is there a basic test for kselftest infrastructure? It seems it was always reporting error when building it :( > thanks, > -- Shuah -- Thanks, Changbin Du -- To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
