On 23 February 2018 at 08:05, Zong Li <zongbox@xxxxxxxxx> wrote: > 2018-02-23 3:57 GMT+08:00 Anders Roxell <anders.roxell@xxxxxxxxxx>: >> On 22 February 2018 at 12:53, Zong Li <zongbox@xxxxxxxxx> wrote: >>> Since the 'commit d3deafaa8b5c ("lib/: make RUNTIME_TESTS a menuconfig >>> to ease disabling it all")', the make kselftest-merge cannot merge the >>> config dependencies of kselftest to the existing .config file. >>> >>> These config dependencies of kselftest need to enable the >>> 'CONFIG_RUNTIME_TESTING_MENU=y' at the same time. >> >> Is this patch needed when patch sha 'f29c79906064 ("lib/Kconfig.debug: enable >> RUNTIME_TESTING_MENU")' find its way into the kernel ? >> I think it's in linux-next now. > > Thanks. The patch sha 'f29c79906064 ("lib/Kconfig.debug: enable > RUNTIME_TESTING_MENU")' can resolve the make kselftest-merge > on default situation, but I think the kselftest-merge should resolve > the dependencies > without the prerequisite, it should enable the 'RUNTIME_TESTING_MENU' > when merging > the config of some selftests if RUNTIME_TESTING_MENU is not set. I see your point, but should the be enabled in a common place that gets included per default if running kselftest-merge and not in all config fragments? Cheers, Anders -- To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html