Re: [PATCH net-next 02/14] selftests: forwarding: Add a test for FDB learning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Ido Schimmel <idosch@xxxxxxxxxxxx> writes:

> +learning_test()
> +{
> +	local mac=de:ad:be:ef:13:37
> +	local ageing_time
> +	local br_port1=$2	# Connected to `host1_if`.
> +	local host1_if=$3
> +	local host2_if=$4
> +	local bridge=$1

I don't think applying RXT in Bash is appropriate. The ordering of the
local variables should instead follow the order of function arguments,
because that information isn't communicated by the function prototype
itself, unlike C.

Thanks,
Petr
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux