On Tue, Feb 13, 2018 at 02:26:46PM -0700, Shuah Khan wrote: > On 02/07/2018 10:24 AM, Daniel Díaz wrote: > > The Makefile lacks a couple of line continuation backslashes > > in an `if' clause, which produces an error while make'ing: > > > > $ make > > make[1]: Entering directory `/[...]/linux/tools/testing/selftests/futex' > > /bin/sh: -c: line 5: syntax error: unexpected end of file > > make[1]: *** [all] Error 1 > > make[1]: Leaving directory `/[...]/linux/tools/testing/selftests/futex' > > make: *** [all] Error 2 > > What is the failure scenario here? Is this shell specific? What does /bin/sh point to for you? > > Signed-off-by: Daniel Díaz <daniel.diaz@xxxxxxxxxx> > > --- > > tools/testing/selftests/futex/Makefile | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/tools/testing/selftests/futex/Makefile b/tools/testing/selftests/futex/Makefile > > index cea4adc..a63e845 100644 > > --- a/tools/testing/selftests/futex/Makefile > > +++ b/tools/testing/selftests/futex/Makefile > > @@ -12,9 +12,9 @@ all: > > BUILD_TARGET=$(OUTPUT)/$$DIR; \ > > mkdir $$BUILD_TARGET -p; \ > > make OUTPUT=$$BUILD_TARGET -C $$DIR $@;\ > > - if [ -e $$DIR/$(TEST_PROGS) ]; then > > - rsync -a $$DIR/$(TEST_PROGS) $$BUILD_TARGET/; > > - fi > > + if [ -e $$DIR/$(TEST_PROGS) ]; then \ > > + rsync -a $$DIR/$(TEST_PROGS) $$BUILD_TARGET/; \ > > + fi \ > > done > > > > override define RUN_TESTS > > > > Thanks for the patch. Applied to linux-kselftest fixes for 4.16-rc3 > > thanks, > -- Shuah > -- Darren Hart VMware Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
