On 10/31/2017 10:23 PM, Masami Hiramatsu wrote: > On Tue, 31 Oct 2017 17:44:32 -0400 > Steven Rostedt <rostedt@xxxxxxxxxxx> wrote: > >> On Tue, 31 Oct 2017 23:51:42 +0900 >> Masami Hiramatsu <mhiramat@xxxxxxxxxx> wrote: >> >>> diff --git a/tools/testing/selftests/ftrace/test.d/kprobe/busy_check.tc b/tools/testing/selftests/ftrace/test.d/kprobe/busy_check.tc >>> index 74507db8bbc8..b8701fa0b8f2 100644 >>> --- a/tools/testing/selftests/ftrace/test.d/kprobe/busy_check.tc >>> +++ b/tools/testing/selftests/ftrace/test.d/kprobe/busy_check.tc >>> @@ -8,7 +8,7 @@ echo > kprobe_events >>> echo p:myevent _do_fork > kprobe_events >>> test -d events/kprobes/myevent >>> echo 1 > events/kprobes/myevent/enable >>> -echo > kprobe_events && exit 1 # this must fail >>> +echo > kprobe_events && exit_fail >> >> Should we keep the comment about "this must fail", otherwise it may >> look like a mistake. Echoing in kprobe_events returns failure here? > > Ah, good catch! I misread the comment is for "exit 1"... > > Thank you, > >> >> -- Steve >> >> >>> echo 0 > events/kprobes/myevent/enable >>> echo > kprobe_events # this must succeed >>> clear_trace > > Hi Masami, Thanks Steve for the catch. I will wait for v2 then. thanks, -- Shuah -- To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
