On 08/16/2017 12:05 AM, Thomas Richter wrote: > On s390x the compilation of the file sas.c in directory > tools/testing/selftests/sigaltstack fails with this error message: > > [root@s8360046 sigaltstack]# make > gcc -Wall sas.c -o /root/linux/tools/testing/selftests/sigaltstack/sas > sas.c: In function ‘my_usr1’: > sas.c:40:25: error: invalid register name for ‘sp’ > register unsigned long sp asm("sp"); > ^~ > ../lib.mk:62: recipe for target '/root/linux/tools/testing/selftests/sigaltstack/sas' failed > make: *** [/root/linux/tools/testing/selftests/sigaltstack/sas] Error 1 > [root@s8360046 sigaltstack]# > > On s390x the stack pointer is register r15, the register name "sp" > is unknown. > Make this line platform dependend and use register r15. > > Which this patch the compilation and test succeeds: > > [root@s8360046 sigaltstack]# make > gcc -Wall sas.c -o /root/linux/tools/testing/selftests/sigaltstack/sas > [root@s8360046 sigaltstack]# ./sas > [OK] Initial sigaltstack state was SS_DISABLE > [RUN] signal USR1 > [OK] sigaltstack is disabled in sighandler > [RUN] switched to user ctx > [RUN] signal USR2 > [OK] Stack preserved > [OK] sigaltstack is still SS_AUTODISARM after signal > [OK] Test passed > [root@s8360046 sigaltstack]# > > Signed-off-by: Thomas Richter <tmricht@xxxxxxxxxxxxxxxxxx> Applied to linux-kselftest fixes for 4.14-rc2 thanks, -- Shuah -- To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html