Hi Naresh, On 09/19/2017 06:37 AM, Naresh Kamboju wrote: > Hi Shuah, > > My two cents, > The "cpupower" command is the pre-requirement of intel_pstate test case. > Would it be a good idea to check, cpupower is pre-installed inside run.sh? > If command not found exit gracefully. > I noticed the failure. > which cpupower > if [ $? -eq 1 ]; then > echo "cpupower: command not found" > echo "intel_pstate: [SKIP]" > exit 0 > fi Yes. It is a good idea. I would change the message to say "Please install cpupower to run intel_pstate" though, instead of command not found. Please send a patch in if you have the time to do so. thanks, -- Shuah -- To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
