From: Dan Carpenter <dan.carpenter@xxxxxxxxxx> Most checks will check for min and then max, except the int check. Flip the checks to be consistent with the other code. Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> [mcgrof: massaged commit log] Signed-off-by: Luis R. Rodriguez <mcgrof@xxxxxxxxxx> --- lib/test_kmod.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/test_kmod.c b/lib/test_kmod.c index 67fc7b9f41e3..fba78d25e825 100644 --- a/lib/test_kmod.c +++ b/lib/test_kmod.c @@ -946,7 +946,7 @@ static int test_dev_config_update_int(struct kmod_test_device *test_dev, if (ret) return ret; - if (new > INT_MAX || new < INT_MIN) + if (new < INT_MIN || new > INT_MAX) return -EINVAL; mutex_lock(&test_dev->config_mutex); -- 2.11.0 -- To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
