On Fri, Jun 30, 2017 at 09:50:55PM -0500, Daniel Díaz wrote: > The ip tool might be provided by another package (such as > Busybox), not necessarily implementing the -Version switch. > Just using `type' helps in finding a usable implementation. > > Signed-off-by: Daniel Díaz <daniel.diaz@xxxxxxxxxx> > --- > tools/testing/selftests/net/netdevice.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/net/netdevice.sh b/tools/testing/selftests/net/netdevice.sh > index 4e00568..ee5926e 100755 > --- a/tools/testing/selftests/net/netdevice.sh > +++ b/tools/testing/selftests/net/netdevice.sh > @@ -178,7 +178,7 @@ if [ "$(id -u)" -ne 0 ];then > exit 0 > fi > > -ip -Version 2>/dev/null >/dev/null > +type ip 2>/dev/null >/dev/null > if [ $? -ne 0 ];then > echo "SKIP: Could not run test without the ip tool" > exit 0 Hello I prefer to have both way via an "if then else elseif" It will permit to detect which ip tool is used and handle futur workaround easier. It will also permit to add more way to detect it. Furthermore, since the script use /bin/sh, I am not sure that all other shell handle "type". Regards Corentin Labbe -- To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
