Re: [PATCH v2 0/2] kselftest: make ksft_* output functions variadic

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 06/28/2017 08:40 AM, Paul Elder wrote:
> It's getting really tedious to have to snprintf a formatted string
> into a char buf before actually feeding the buf to ksft_* output
> so the ksft_* output functions are now variadic so that we can
> format the output directly within the output function.
> 
> Also a generic informative ksft output function was added.
> 
> Changes from v1: Removed auto-inserted newline character from functions
> where the caller specifies a message string.
> 
> Paul Elder (2):
>   kselftest: make ksft_* output functions variadic
>   kselftest: add ksft_print_msg() function to output general information
> 
>  tools/testing/selftests/kselftest.h | 65 ++++++++++++++++++++++++++++++-------
>  1 file changed, 53 insertions(+), 12 deletions(-)
> 

Hi Paul,

Based on the test results with breakpoint_test_arm64, the v1 series output
looks better. I am going with your v1.

thanks,
-- Shuah

--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux