On 06/28/2017 08:36 AM, Fathi Boudra wrote: > On 28 June 2017 at 17:19, Shuah Khan <shuah@xxxxxxxxxx> wrote: >> On 06/28/2017 05:19 AM, Fathi Boudra wrote: >>> reuseport_bpf_numa fails to build with undefined reference: >>> >>> aarch64-linaro-linux-gcc >>> --sysroot=/build/tmp-rpb-glibc/sysroots/hikey -Wall >>> -Wl,--no-as-needed -O2 -g -I../../../../usr/include/ -Wl,-O1 >>> -Wl,--hash-style=gnu -Wl,--as-needed -lnuma reuseport_bpf_numa.c >>> -o >>> /build/tmp-rpb-glibc/work/hikey-linaro-linux/kselftests/4.12-r0/linux-4.12-rc7/tools/testing/selftests/net/reuseport_bpf_numa >>> /tmp/ccfUuExT.o: In function `send_from_node': >>> /build/tmp-rpb-glibc/work/hikey-linaro-linux/kselftests/4.12-r0/linux-4.12-rc7/tools/testing/selftests/net/reuseport_bpf_numa.c:138: >>> undefined reference to `numa_run_on_node' >>> /tmp/ccfUuExT.o: In function `main': >>> /build/tmp-rpb-glibc/work/hikey-linaro-linux/kselftests/4.12-r0/linux-4.12-rc7/tools/testing/selftests/net/reuseport_bpf_numa.c:230: >>> undefined reference to `numa_available' >>> /build/tmp-rpb-glibc/work/hikey-linaro-linux/kselftests/4.12-r0/linux-4.12-rc7/tools/testing/selftests/net/reuseport_bpf_numa.c:233: >>> undefined reference to `numa_max_node' >>> >>> Use LDLIBS instead of LDFLAGS to properly link against libnuma. >>> >>> Signed-off-by: Fathi Boudra <fathi.boudra@xxxxxxxxxx> >> >> Did you try this on linux-ksefltest next? It has the fix for this. > > yes, I tried linux-ksefltest next and can reproduce. My question is whether this fix is on top of linux-kselftest next. > >> thanks, >> -- Shuah >>> --- >>> tools/testing/selftests/net/Makefile | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/tools/testing/selftests/net/Makefile b/tools/testing/selftests/net/Makefile >>> index 35cbb4cba410..17c732a19c4c 100644 >>> --- a/tools/testing/selftests/net/Makefile >>> +++ b/tools/testing/selftests/net/Makefile >>> @@ -3,7 +3,7 @@ >>> CFLAGS = -Wall -Wl,--no-as-needed -O2 -g >>> CFLAGS += -I../../../../usr/include/ >>> >>> -reuseport_bpf_numa: LDFLAGS += -lnuma >>> +reuseport_bpf_numa: LDLIBS += -lnum >>> >>> TEST_PROGS := run_netsocktests run_afpackettests test_bpf.sh netdevice.sh >>> TEST_GEN_FILES = socket > Please redo the patch on top of SeongJae Park's fix selftest/net/Makefile: Specify output with $(OUTPUT) btw - with the the above fix, I don't see any failures on x86_64. I am curious why it fails in cross-build? Could you figure out if your cross-build environment is good. thanks, -- Shuah -- To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
