Re: [PATCH v2 2/3] kselftest: membarrier: make test names more informative

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 06/15/2017 10:19 AM, Paul Elder wrote:
> From: Alice Ferrazzi <alice.ferrazzi@xxxxxxxxx>
> 
> Make membarrier test names more informative.
> 
> Signed-off-by: Alice Ferrazzi <alice.ferrazzi@xxxxxxxxx>
> Signed-off-by: Paul Elder <paul.elder@xxxxxxxx>
> ---
> v2: Give authorship to Alice - Paul
> 
>  tools/testing/selftests/membarrier/membarrier_test.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/testing/selftests/membarrier/membarrier_test.c
> b/tools/testing/selftests/membarrier/membarrier_test.c
> index cae8c984dfb0..7925fcf9262b 100644
> --- a/tools/testing/selftests/membarrier/membarrier_test.c
> +++ b/tools/testing/selftests/membarrier/membarrier_test.c
> @@ -21,7 +21,7 @@ static int sys_membarrier(int cmd, int flags)
>  static enum test_membarrier_status test_membarrier_cmd_fail(void)
>  {
>  	int cmd = -1, flags = 0;
> -	const char *test_name = "membarrier command fail";
> +	const char *test_name = "membarrier command cmd=-1. Wrong command should fail";
> 
>  	if (sys_membarrier(cmd, flags) != -1) {
>  		ksft_test_result_fail(test_name);
> @@ -35,7 +35,7 @@ static enum test_membarrier_status test_membarrier_cmd_fail(void)
>  static enum test_membarrier_status test_membarrier_flags_fail(void)
>  {
>  	int cmd = MEMBARRIER_CMD_QUERY, flags = 1;
> -	const char *test_name = "Wrong flags should fail";
> +	const char *test_name = "MEMBARRIER_CMD_QUERY, flags=1, Wrong flags should fail";
> 
>  	if (sys_membarrier(cmd, flags) != -1) {
>  		ksft_test_result_fail(test_name);
> 

Applied this to linux-kselftest next for 4.13-rc1

This probably is the last patch that will go into 4.13-rc1 for this first
round of TAP v13 work. We are at 4.12-rc5 now and getting close to the
release time.

thanks,
-- Shuah
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux