On 06/15/2017 08:50 AM, Alice Ferrazz wrote: > From: Alice Ferrazzi <alice.ferrazzi@xxxxxxxxx> > > Added yaml output to kselftest. > Added reason yaml output to kcmp. > > Alice Ferrazzi (2): > Added yaml output to kselftest. > Used the reason on kcmp. > > tools/testing/selftests/kcmp/kcmp_test.c | 12 ++++++------ > tools/testing/selftests/kselftest.h | 12 +++++++++--- > 2 files changed, 15 insertions(+), 9 deletions(-) > Hi Alice, Let's hold off on YAML block for a bit. I am concerned about the non-dynamic string requirement Tim brought up. So let's wait on this series until we understand clearly what are the YAML block requirements, before implementing support for it. As I pointed out in my response to the earlier discussion on this [PATCH v3 5/5] kselftest: kcmp: Port kcmp test to TAP v13, there are few things I am concerned about: 1. Being able to append strerror(errorno) information to the fail/skip messages 2. Parent/child logic - lots of tests run the actual test in a child process. I also want to understand what is the value YAML brings to Kselftest as a whole, as opposed to saying let's add it because it is in TAP13. thanks, -- Shuah -- To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
