Re: [PATCH v2] kselftest: convert get_size to use stricter TAP13 format

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Tim,

On 06/14/2017 12:22 PM, Bird, Timothy wrote:
> 
> 1. Add the TAP13 header
> 2. remove variable data from the test description line
> 3. move the plan count to the end of the file, for consistency with
> other kselftests
> 4. convert memory data from diagnostic (comment) format, to a YAML block
> 
> Signed-off-by: Tim Bird <tim.bird@xxxxxxxx>
> ---
> v2: add Signed-off-by line

How did you send this patch? My email client decodes it fine, but mbox
file is encoded.

Are you using git send-email?

thanks,
-- Shuah
> 
>  tools/testing/selftests/size/get_size.c | 27 ++++++++++++++++-----------
>  1 file changed, 16 insertions(+), 11 deletions(-)
> 
> diff --git a/tools/testing/selftests/size/get_size.c b/tools/testing/selftests/size/get_size.c
> index 2d1af7c..d4b59ab 100644
> --- a/tools/testing/selftests/size/get_size.c
> +++ b/tools/testing/selftests/size/get_size.c
> @@ -75,26 +75,31 @@ void _start(void)
>  	int ccode;
>  	struct sysinfo info;
>  	unsigned long used;
> +	static const char *test_name = " get runtime memory use\n";
>  
> -	print("Testing system size.\n");
> -	print("1..1\n");
> +	print("TAP version 13\n");
> +	print("# Testing system size.\n");
>  
>  	ccode = sysinfo(&info);
>  	if (ccode < 0) {
> -		print("not ok 1 get runtime memory use\n");
> -		print("# could not get sysinfo\n");
> +		print("not ok 1");
> +		print(test_name);
> +		print(" ---\n reason: \"could not get sysinfo\"\n ...\n");
>  		_exit(ccode);
>  	}
> +	print("ok 1");
> +	print(test_name);
> +
>  	/* ignore cache complexities for now */
>  	used = info.totalram - info.freeram - info.bufferram;
> -	print_k_value("ok 1 get runtime memory use # size = ", used,
> -		info.mem_unit);
> -
>  	print("# System runtime memory report (units in Kilobytes):\n");
> -	print_k_value("#   Total:  ", info.totalram, info.mem_unit);
> -	print_k_value("#   Free:   ", info.freeram, info.mem_unit);
> -	print_k_value("#   Buffer: ", info.bufferram, info.mem_unit);
> -	print_k_value("#   In use: ", used, info.mem_unit);
> +	print(" ---\n");
> +	print_k_value(" Total:  ", info.totalram, info.mem_unit);
> +	print_k_value(" Free:   ", info.freeram, info.mem_unit);
> +	print_k_value(" Buffer: ", info.bufferram, info.mem_unit);
> +	print_k_value(" In use: ", used, info.mem_unit);
> +	print(" ...\n");
> +	print("1..1\n");
>  
>  	_exit(0);
>  }
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux