Re: [PATCH 0/4] kselftest: add TAP13 output format

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 06/09/2017 02:23 AM, Greg Kroah-Hartman wrote:
> Hi,
> 
> Last week at LinuxCon Japan (or whatever the conference has renamed
> itself to...) Tim Bird mentioned that it would be great to have the
> output of kselftests be in a "standard" format, so that people don't
> have to write a bunch of custom parsers when they implement kselftest in
> their test environment.

Thanks for starting this off. We have several tests now and the number
keeps growing. It has become difficult to identify run to run differences.

> 
> He pointed out that the TAP format is especially good, it's been around
> for forever, is light and easy to use, and everyone already has parsers
> for it.  The details on the latest version of the spec can be found
> here:
> 	https://testanything.org/tap-version-13-specification.html
> 
> I mentioned that Paul and Alice (on cc: here) were looking for ways to
> contribute to the kernel, and so here's a first series of patches,
> ostensibly authored by Paul, but contributed heavily by me and Alice at
> the same time (multiple authorship is hard for kernel patches...)
> 
> These patches add an initial framework to the kselftest header file to
> provide a way for tests to output in TAP13 format, and then goes on to
> convert 3 different tests to use the format, showing that it does work
> well.
> 
> Note, the names for the api calls are a bit unwieldy, if anyone has
> suggestions for what could be used instead, please do so.

I briefly looked at the get_size.c and have been thinking along the
same lines that the get_size print routines could be leveraged and
turned into common API in kselftest.h for all tests to use.

It is the along the same lines as the direction this patch series
takes.

Comments in individual patches.

thanks again for this series.

-- Shuah

> 
> Thoughts?
> 
> thanks,
> 
> greg k-h
> 
> Paul Elder (4):
>   kselftest: add TAP13 conformant versions of ksft_* functions
>   kselftest: membarrier: convert to TAP13 output
>   kselftest: breakpoints: convert breakpoint_test to TAP13 output
>   kselftest: breakpoints: convert step_after_suspend_test to TAP13
>     output
> 
>  .../selftests/breakpoints/breakpoint_test.c        | 31 ++++-----
>  .../breakpoints/step_after_suspend_test.c          | 47 ++++++-------
>  tools/testing/selftests/kselftest.h                | 77 ++++++++++++++++++++++
>  .../testing/selftests/membarrier/membarrier_test.c | 45 +++++++------
>  4 files changed, 136 insertions(+), 64 deletions(-)
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux