Re: [PATCH v2 0/2] selftests: watchdog: get boot reason via WDIOC_GETBOOTSTATUS

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 05/28/2017 01:53 PM, Eugeniu Rosca wrote:
> Implement WDIOC_GETBOOTSTATUS in test code to be able to check if
> watchdog drivers have proper support of WDIOF_CARDRESET. Include a
> segmentation fault fix, as it might generate merge conflicts if
> provided separately.
> 
> v2:
> - Fix segmentation fault caused by a previous commit.
> - Don't break processing of other arguments when passing `-s`.
> 
> Eugeniu Rosca (2):
>   selftests: watchdog: fix segmentation fault due to wrong argv parsing

Please fix this using getopt. The argument processing is getting very
complex. You can void these wrong index type that way.


>   selftests: watchdog: get boot reason via WDIOC_GETBOOTSTAT

Please add this new argument on top of the patch that converts to
getopt.

thanks,
-- Shuah

> 
>  tools/testing/selftests/watchdog/watchdog-test.c | 13 +++++++++++--
>  1 file changed, 11 insertions(+), 2 deletions(-)
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux