On Wed, Jan 11, 2017 at 07:41:07AM -0700, Shuah Khan wrote: > On 01/11/2017 01:48 AM, Stafford Horne wrote: > > On Wed, Jan 11, 2017 at 12:07:55AM -0800, Darren Hart wrote: > >> On Wed, Jan 11, 2017 at 01:37:19PM +0900, Stafford Horne wrote: > >>> On Tue, Jan 10, 2017 at 02:17:18PM -0800, Darren Hart wrote: > >>>> On Tue, Jan 10, 2017 at 02:10:42PM -0800, Darren Hart wrote: > >>>>> On Fri, Jan 06, 2017 at 01:18:39PM +0900, Stafford Horne wrote: > >>>>>> I am working on doing selftests for openrisc and found issues with the > >>>>>> futex test is not building after changes to the tests source. > >>>>>> > >>>>>> This issue is that the TARGETS variable used in the futex Makefile is > >>>>>> also used by the selftests Makefile, so when building from toplevel the > >>>>>> TARGETS variable is clobbered and nothing gets built. Changed the > >>>>>> variable name to get around that. > >>>>>> > >>>>>> Also, the futex makefile did not contain dependencies for all headers, > >>>>>> so if we make changes to logging.h rebuild will not happen. Add headers > >>>>>> to fix it up. > >>>>>> > >>>>>> Signed-off-by: Stafford Horne <shorne@xxxxxxxxx> > >>>>> > >>>>> Thanks for catching this and the fix. > >>>>> > >>>>> +Shuah Khan > >>>>> > >>>>> Note: This appears also to be a problem for intel_pstate/Makefile > >>>> > >>>> Or, it would be if intel_pstate was listed in selftests/Makefile :-) > >>> > >>> Right, thanks for having a look. I actually have a small patch to also > >>> add <stdio.h> to logging.h. If you have not already fixed the > >>> intel_pstate test I'll send them all together. > >> > >> Please do, thanks! > > > > Hello, > > Actually I just had a look at Shuah's linux-kselftest repo on > > kernel.org. It looks like Bamvor Jian has actually fixed a lot of these > > issues on the next branch. > > > > I will see what is missing if anything. > > > > -Stafford > > > > > > Hi Stafford, > > Thanks for looking into the issues. Yes Bemovar fixed several issues. > Could you please send me the patches you alre > > If you think [PATCH] selftests/futex: Fix makefile dependencies > should be pulled in, please send it to me. I just Darren's response, > don't have the original patch email in my Inbox. Hello Shuah, There was a conflict with my patch and Bamvor's. As you make have seen, I have resolved those conflicts and sent a few more patches in new series. 2/6 is what has become of the original patch that Darren reviewed. I didn't keep Reviewed-by since its completely different now, I will wait for review of the others. -Stafford -- To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
