Shuah, May I ask your opinion about this patch? Thanks, SeongJae Park On Sun, Jun 19, 2016 at 2:50 AM, Kees Cook <keescook@xxxxxxxxxxxx> wrote: > On Sat, Jun 18, 2016 at 2:28 AM, SeongJae Park <sj38.park@xxxxxxxxx> wrote: >> Test for test_printf module fails always because the test program, >> printf.sh, has no execution permission. This commit adds execution >> permission to it. >> >> Signed-off-by: SeongJae Park <sj38.park@xxxxxxxxx> > > Acked-by: Kees Cook <keescook@xxxxxxxxxxxx> > > (Is this mode change sufficient, or does the selftest infrastructure > need to explicitly set it executable when running?) > > -Kees > > >> --- >> tools/testing/selftests/lib/printf.sh | 0 >> 1 file changed, 0 insertions(+), 0 deletions(-) >> mode change 100644 => 100755 tools/testing/selftests/lib/printf.sh >> >> diff --git a/tools/testing/selftests/lib/printf.sh b/tools/testing/selftests/lib/printf.sh >> old mode 100644 >> new mode 100755 >> -- >> 1.9.1 >> > > > > -- > Kees Cook > Chrome OS & Brillo Security -- To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
