On 15/06/16 03:49 PM, Allen Hubbe wrote:
>> +function link_test()
>> +{
>> + LOC=$1
>> + REM=$2
>> + EXP=0
>> +
>> + echo "Running link tests on: $(basename $LOC) / $(basename $REM)"
>> +
>> + write_file "N" "$LOC/link"
>> + write_file "N" "$LOC/link_event"
>
> If it fails to bring down the link, won't it just block waiting on link_event and never make it to the next step of the test?
>
>> + if [[ $(read_file "$REM/link") != "N" ]]; then
>> + echo "Expected remote link to be down in $REM/link" >&2
>> + exit -1
>> + fi
>> +
>> + write_file "Y" "$LOC/link"
>> + write_file "Y" "$LOC/link_event"
>> +
>> + echo " Passed"
>> +}
Well, the test is really intended to ensure both sides of the link see
changes to the link status. If the driver is somehow buggy and the link
never goes down/up when requested there's little I can do here except
block forever. Unless we want to add a timeout to the link_event file
(which I'd rather not).
You'd have the same issue if, when bringing the link up for the first
time, the link does not come back.
Logan
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
