On 06/14/2016 01:15 PM, Yannick Brosseau wrote: > On 06/14/2016 12:09 PM, Shuah Khan wrote: >> On 06/14/2016 12:45 PM, Yannick Brosseau wrote: >>> When running the execveat test once installed, the Makefile it not available and the >>> test fail. Bundling the Makefile file with the installed files fix that. >> Install is for installing kselftest binaries and run-time dependencies >> if any on a target system. It is not for being able to build it on the >> target. Bundling Makefile doesn't make sense. > The test tries to exec the Makefile file: > fail += check_execveat_fail(dot_dfd, "Makefile", 0, EACCES); > > So it's a runtime dependency at the moment. > We can either change the test to try to open another file or add the > Makefile Ah I see why Makefile is necessary. No point in adding a new file. Please add a comment in the file to indicate that Makefile is a run-time dependency. Could you also rephrase the change log to make it clear that Makefile is run-time dependency. Thanks for catching it. -- Shuah -- To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
