From: Logan Gunthorpe > On 14/06/16 09:45 AM, Allen Hubbe wrote: > > > > Feel free to disregard my suggestion above. I hope my comment has not cost you too much > time. > > > > The way you have written it already, and used it in the self-test script is much more > concise. > > > >>> + * root@self# echo > $DBG_DIR/link > > > > Acked-by: Allen.Hubbe@xxxxxxx > > > > > > > > Eventually, I think it would be useful to let ntb_tool enable and disable the link. In > that case, it might also be useful in a test script to wait for link down, not just link > up. > > > > What about this: > > > > # Wait for the link to be up or down > > root@self# echo 1 > $DBG_DIR/link > > root@self# echo 0 > $DBG_DIR/link > > > > It need not be a part of this patch, but eventually: > > > > # Enable or disable the link > > root@self# echo 1 > $DBG_DIR/link_ctrl > > root@self# echo 0 > $DBG_DIR/link_ctrl > > > > # Reading the link_ctrl file can also give the link status > > root@self# cat $DBG_DIR/link_ctrl > > > > Finally, I wonder if the file called "link" in this patch should be called "link_wait" > or similar, so its purpose is obviously not for enabling and disabling the link. > > > > Actually I've already implemented something similar to your original > suggestion. I'll be submitting a v2 of this set shortly. Ok. Thanks. I'll accept the blame if anyone doesn't like it. -- To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
