Hi, On 18/02/25 21:04, Sven Peter wrote:
Hi, On Wed, Feb 12, 2025, at 09:58, Harshit Mogalapalli wrote:This code calls kfree(bfr); and then passes "bfr" to rtk->ops->crashed() which is a use after free. The ->crashed function pointer is implemented by apple_nvme_rtkit_crashed() and it doesn't use the "bfr" pointer so this doesn't cause a problem. But it still looks sketchy as can be. Fix this by moving kfree() after the last usage of bfr. Fixes: c559645f343a ("soc: apple: rtkit: Pass the crashlog to the crashed() callback")This commit isn't upstream yet afaict, did you mean to post a review comment to [1] instead?
I made the patch based on linux-next, linux-next has the patch merged. Thanks, Harshit
[1] https://lore.kernel.org/asahi/20250202-rtkit-crashdump-v1-1-9d38615b4e12@xxxxxxxxxxxxx/ Best, Sven
