[PATCH v2] staging: gpib: Remove unnecessary TTY_LOG expansion

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



When drivers are successful, they should be quiet.

Remove the unnecessary TTY_LOG expansion.

Suggested-by: Greg KH <greg@xxxxxxxxx>
Signed-off-by: Andrew Kreimer <algonell@xxxxxxxxx>
---
v2:
  - Change commit message/body.
  - Remove the TTY_LOG line as suggested.

v1:
  - Fix a typo in TTY_LOG message.

 drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c b/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c
index 85322af62c23..b2c4d1d26f12 100644
--- a/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c
+++ b/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c
@@ -542,7 +542,6 @@ static int usb_gpib_attach(gpib_board_t *board, const gpib_board_config_t *confi
 		return -EIO;
 
 	SHOW_STATUS(board);
-	TTY_LOG("Module '%s' has been sucesfully configured\n", NAME);
 	return 0;
 }
 

Interdiff against v1:
  diff --git a/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c b/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c
  index 1c3e5dfcc9ec..b2c4d1d26f12 100644
  --- a/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c
  +++ b/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c
  @@ -542,7 +542,6 @@ static int usb_gpib_attach(gpib_board_t *board, const gpib_board_config_t *confi
   		return -EIO;
   
   	SHOW_STATUS(board);
  -	TTY_LOG("Module '%s' has been successfully configured\n", NAME);
   	return 0;
   }
   

Range-diff against v1:
1:  779e59d74722 ! 1:  463e7000d1a7 staging: gpib: Fix typo in TTY_LOG message
    @@ Metadata
     Author: Andrew Kreimer <algonell@xxxxxxxxx>
     
      ## Commit message ##
    -    staging: gpib: Fix typo in TTY_LOG message
    +    staging: gpib: Remove unnecessary TTY_LOG expansion
     
    -    There is a typo in TTY_LOG message:
    -     - sucesfully -> successfully
    +    When drivers are successful, they should be quiet.
     
    -    Fix it via codespell.
    +    Remove the unnecessary TTY_LOG expansion.
     
    +    Suggested-by: Greg KH <greg@xxxxxxxxx>
         Signed-off-by: Andrew Kreimer <algonell@xxxxxxxxx>
     
      ## drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c ##
    @@ drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c: static int usb_gpib_attach(g
      
      	SHOW_STATUS(board);
     -	TTY_LOG("Module '%s' has been sucesfully configured\n", NAME);
    -+	TTY_LOG("Module '%s' has been successfully configured\n", NAME);
      	return 0;
      }
      
-- 
2.48.1.268.g9520f7d998





[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux